Create Rotated_Binary_Search.java #3795
Conversation
Searching in the rotated Binary search
raman04-byte
requested review from
debasishbsws,
siriak and
yanglbme
as code owners
siriak
left a comment
siriak
left a comment
There was a problem hiding this comment.
The code looks good, could you please add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)
|
I don't know how to add JUnit test
…On Fri, Dec 16, 2022 at 3:15 PM Andrii Siriak ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The code looks good, could you please add some JUnit tests? (see
https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms
)
—
Reply to this email directly, view it on GitHub
<#3795 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASESLGTZEJ6RG3YXETUOJW3WNQ2Z3ANCNFSM6AAAAAATAELKDU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| return Binarysearch(nums, target, pivot+1, nums.length-1); | ||
| } | ||
|
|
||
| static int Binarysearch(int[] arr, int target, int start, int end) { |
There was a problem hiding this comment.
This function name should follow camel case.'B' should be small.
You can go to the provided link and take a look of other JUnit tests code, and make one for yours too. It was very simple you will get it. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
4 participants
Searching in the rotated Binary search